Open
Conversation
kernc
requested changes
Dec 20, 2025
Owner
kernc
left a comment
kernc
left a comment
There was a problem hiding this comment.
Apologies for the late review. Some comments left ...
Author
|
I believe I've addressed all the concerns you had, let me know anything I missed! |
…ather than generating the full slice first. ~12% speed improvement
…changing positions at all. ~13% time saving
kernc
force-pushed
the
speed-improvements2
branch
from
7617d6e to
78860da
Compare
But keep accessors rather than stringly types.
Owner
|
Apologies! At first I had a few nitpick last word ideas I didn't intend to fuss over, but then it turned out into this many. I also rebased everything on the current master, and expect to squash when merged. Please take a look! I feel, even if not strictly evident from the CI run times, that this should reduce computational overhead at least of strategies with lots of trades. 👍 |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've included here some speed enhancements from my video:
https://youtu.be/LSo4ghiAPvk
Running the SMA strategy from the README on my machine this PR gives a roughly 40% reduction in total runtime for
bt.runTests all pass